Allow future addition of Histogram MinMax via View #2705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Nov 29, 2021
Codecov Report
@@ Coverage Diff @@
## main #2705 +/- ##
==========================================
+ Coverage 82.93% 82.96% +0.02%
==========================================
Files 249 250 +1
Lines 8704 8705 +1
==========================================
+ Hits 7219 7222 +3
+ Misses 1485 1483 -2
|
alanwest
approved these changes
Nov 29, 2021
utpilla
reviewed
Nov 29, 2021
|
|
||
| namespace OpenTelemetry.Metrics | ||
| { | ||
| public class HistogramConfiguration : MetricStreamConfiguration |
There was a problem hiding this comment.
Do we want to make this an abstract class?
There was a problem hiding this comment.
We need things like below in the future.
.AddView(instrumentName: "MyHistogram", new HistogramConfiguration() { Name = "newname", RecordMinMax = false })
|
@utpilla is checking if this can be added after 1.2.0 as well, if yes, will revert to avoid the confusion when one uses this: This can be added after |
cijothomas
pushed a commit
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinMax is not supported currently, so not exposing any setting for that publicly. But this introduces a base class
HistogramConfigurationto holdRecordMinMaxas it'll be applied toExplicitBucketHistogramandExponentialHistogram(when that feature is added). Alternate would be to addRecordMinMaxto bothExplicitBucketHistogramandExponentialHistogram